Skip to content

Add animation effect for navigation entries#8685

Open
jancborchardt wants to merge 1 commit into
mainfrom
feat/animate-app-navigation-highlight
Open

Add animation effect for navigation entries#8685
jancborchardt wants to merge 1 commit into
mainfrom
feat/animate-app-navigation-highlight

Conversation

@jancborchardt

@jancborchardt jancborchardt commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

☑️ Resolves

It would be nice to have an animation of the hover feedback highlight of the NcAppNavigation. This makes it feel nicer and smoother, like you are actually interacting with something.

This is a prototype to see how that could look like. Has been tested in the styleguide.
@susnux @ShGKme please check if this would this be good as a base, or should take a different approach.

🖼️ Screenshots

🏚️ Before

Screencast.From.2026-06-27.01-40-20.webm

🏡 After

Screencast.From.2026-06-27.01-34-40.webm

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

Assisted-by: ClaudeCode:claude-opus-4-8

@jancborchardt jancborchardt self-assigned this Jun 26, 2026
@jancborchardt jancborchardt added enhancement New feature or request 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component design Design, UX, interface and interaction design labels Jun 26, 2026
@jancborchardt jancborchardt moved this to 🏗️ At engineering in 🖍 Design team Jun 26, 2026
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.69%. Comparing base (fef17a7) to head (d9f5550).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8685      +/-   ##
==========================================
+ Coverage   53.10%   53.69%   +0.58%     
==========================================
  Files         106      106              
  Lines        3544     3589      +45     
  Branches     1023     1033      +10     
==========================================
+ Hits         1882     1927      +45     
  Misses       1406     1406              
  Partials      256      256              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@susnux

susnux commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

I do not see anything in the "after" screencast that requires JS changes, that should be possible with pure CSS so no heavy mutation observer is required, no?

@jancborchardt jancborchardt force-pushed the feat/animate-app-navigation-highlight branch from 47d32da to 573da00 Compare June 30, 2026 13:25
Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>
@jancborchardt jancborchardt force-pushed the feat/animate-app-navigation-highlight branch from 573da00 to d9f5550 Compare June 30, 2026 13:40
@jancborchardt

Copy link
Copy Markdown
Contributor Author

@susnux adjusted the PR to use minimal needed JS, also rebased and tests fixed.

@jancborchardt jancborchardt marked this pull request as ready for review June 30, 2026 13:54
@susnux

susnux commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

what is the difference between this JS implementation and a simple CSS on hover animation?

@jancborchardt

Copy link
Copy Markdown
Contributor Author

@susnux the CSS :hover fades the bg of each entry in place. The JS moves that single highlight that slides from the old entry to the new one. That travel between separate elements can’t be done by CSS alone cause a transition can only work on the properties of an element itself but not on siblings.

@jancborchardt

Copy link
Copy Markdown
Contributor Author

(Maybe it’s not super obvious on the screencast, especially in the top part where there’s an active element. But there is a background highlight which looks like it travels across the different entries.)

@jancborchardt jancborchardt changed the title feat: Add animation effect for navigation entries Add animation effect for navigation entries Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Design, UX, interface and interaction design enhancement New feature or request feature: app-navigation Related to the app-navigation component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants